Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker][branch-3.0] Add fine-grain authorization to ns/topic management endpoints #22309

Merged
merged 2 commits into from Mar 20, 2024

Conversation

Technoboy-
Copy link
Contributor

This is cherry-picking #22305

Motivation

Add fine-grain authorization to ns/topic management endpoints so that it can be controlled at a more fine-grain level.

Modification

  • TRIM_TOPIC was missing, this would cause the normal user throw IllegalStateException not NotAuthorizedException.
  • adding fine-grain authorization to internalSetProperty, internalSetProperties, internalGetProperty, internalGetProperties, internalRemoveProperty, internalClearProperties, internalUnloadTopic,internalGetManagedLedgerInfo, internalGetPartitionedStats, internalGetPartitionedStatsInternal, internalCreateSubscription, internalUpdateSubscriptionProperties, internalAnalyzeSubscriptionBacklog, internalGetSubscriptionProperties, internalCreateMissedPartitions

Verifying this change

  • Add fine-grain authorization test coverage to NamespaceAuthZTest and TopicAuthZTest

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 20, 2024
@Technoboy- Technoboy- self-assigned this Mar 20, 2024
@Technoboy- Technoboy- closed this Mar 20, 2024
@Technoboy- Technoboy- reopened this Mar 20, 2024
@Technoboy- Technoboy- changed the title [improve][broker] Add fine-grain authorization to ns/topic management endpoints [improve][broker][branch-3.0] Add fine-grain authorization to ns/topic management endpoints Mar 20, 2024
@Technoboy- Technoboy- closed this Mar 20, 2024
@Technoboy- Technoboy- reopened this Mar 20, 2024
@Technoboy-
Copy link
Contributor Author

@lhotari The CI seems broken by cherry-picking the #22291, I'm not sure.
Also open a patch to test the CI #22310

@lhotari
Copy link
Member

lhotari commented Mar 20, 2024

@lhotari The CI seems broken by cherry-picking the #22291, I'm not sure. Also open a patch to test the CI #22310

@Technoboy- Ok, I'll check CI.

@lhotari lhotari closed this Mar 20, 2024
@lhotari lhotari reopened this Mar 20, 2024
@lhotari
Copy link
Member

lhotari commented Mar 20, 2024

Pulsar CI maven heapsize increased: 6eb5068a

@lhotari
Copy link
Member

lhotari commented Mar 20, 2024

I increased the heapsize for pulsar-ci-flaky.yaml in a separate commit: e76ed436 . I triggered the test run before this change was made.

@Technoboy- Technoboy- merged commit b51b748 into apache:branch-3.0 Mar 20, 2024
97 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants