[improve][broker] Add fine-grain authorization to ns/topic management endpoints #22305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Mar 19, 2024
codelipenghui
approved these changes
Mar 20, 2024
|
@Technoboy- I have removed the 3.1 release label since 3.1 is out of the support scope. You can get the release policy in this page |
Ok |
coderzc
approved these changes
Mar 20, 2024
mattisonchao
approved these changes
Mar 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22305 +/- ##
============================================
+ Coverage 73.57% 73.62% +0.04%
+ Complexity 32624 32183 -441
============================================
Files 1877 1887 +10
Lines 139502 139471 -31
Branches 15299 15293 -6
============================================
+ Hits 102638 102684 +46
+ Misses 28908 28824 -84
- Partials 7956 7963 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Cherry-picked to branch-3.0 by #22309 |
lhotari
pushed a commit
that referenced
this pull request
Mar 20, 2024
… endpoints (#22305) (cherry picked from commit fd34d4a) # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java (cherry picked from commit 99eb49a) # Conflicts: # pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java (cherry picked from commit 5c4f4cb) # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesAuthZTest.java
lhotari
pushed a commit
that referenced
this pull request
Mar 20, 2024
… endpoints (#22305) (cherry picked from commit fd34d4a) # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java (cherry picked from commit 99eb49a) # Conflicts: # pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
lhotari
added a commit
that referenced
this pull request
Mar 20, 2024
lhotari
added a commit
that referenced
this pull request
Mar 20, 2024
(cherry picked from commit 91ee580)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2024
… endpoints (apache#22305) (cherry picked from commit fd34d4a) Conflicts: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
4 tasks
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2024
… endpoints (apache#22305) (cherry picked from commit fd34d4a)
4 tasks
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 2, 2024
… endpoints (apache#22305) (cherry picked from commit fd34d4a) Conflicts: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2024
… endpoints (apache#22305) (cherry picked from commit fd34d4a)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
… endpoints (apache#22305) (cherry picked from commit fd34d4a) # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java (cherry picked from commit 99eb49a) # Conflicts: # pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java (cherry picked from commit 5c4f4cb) # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesAuthZTest.java
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
(cherry picked from commit 91ee580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add fine-grain authorization to ns/topic management endpoints so that it can be controlled at a more fine-grain level.
Modification
TRIM_TOPICwas missing, this would cause the normal user throwIllegalStateExceptionnot NotAuthorizedException.internalSetProperty,internalSetProperties,internalGetProperty,internalGetProperties,internalRemoveProperty,internalClearProperties,internalUnloadTopic,internalGetManagedLedgerInfo,internalGetPartitionedStats,internalGetPartitionedStatsInternal,internalCreateSubscription,internalUpdateSubscriptionProperties,internalAnalyzeSubscriptionBacklog,internalGetSubscriptionProperties,internalCreateMissedPartitionsVerifying this change
NamespaceAuthZTestandTopicAuthZTestDocumentation
docdoc-requireddoc-not-neededdoc-complete