Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-321 Introduce allowed-cluster at the namespace level #22378

Merged
merged 18 commits into from
Jun 20, 2024

Conversation

liangyepianzhou
Copy link
Contributor

PIP: #21648

Motivation

Because the configurations of clusters at the namespace level are unclear, some flexible topic policies can not work as expected, e.g. geo-replication at the topic level.

Modifications

Use replication-clusters, allowed-clusters to replace a single replication-clusters originally in the namespace policy.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 28, 2024
@liangyepianzhou liangyepianzhou changed the title Replication/topic level [feat][broker] PIP-321 Introduce allowed-cluster at the namespace level Mar 28, 2024
@liangyepianzhou liangyepianzhou self-assigned this Mar 29, 2024
@liangyepianzhou liangyepianzhou added this to the 3.3.0 milestone Mar 29, 2024
@liangyepianzhou liangyepianzhou added the type/feature The PR added a new feature or issue requested a new feature label Mar 29, 2024
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
# Conflicts:
#	pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
@Demogorgon314 Demogorgon314 self-assigned this May 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.12397% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 73.24%. Comparing base (bbc6224) to head (44d0fc1).
Report is 303 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22378      +/-   ##
============================================
- Coverage     73.57%   73.24%   -0.34%     
- Complexity    32624    32642      +18     
============================================
  Files          1877     1890      +13     
  Lines        139502   141584    +2082     
  Branches      15299    15534     +235     
============================================
+ Hits         102638   103702    +1064     
- Misses        28908    29888     +980     
- Partials       7956     7994      +38     
Flag Coverage Δ
inttests 27.45% <19.83%> (+2.87%) ⬆️
systests 24.62% <12.39%> (+0.29%) ⬆️
unittests 72.27% <85.12%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ava/org/apache/pulsar/client/admin/Namespaces.java 66.66% <ø> (ø)
...e/pulsar/client/admin/internal/NamespacesImpl.java 97.67% <100.00%> (+2.22%) ⬆️
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java 79.11% <100.00%> (+0.38%) ⬆️
...apache/pulsar/common/policies/data/PolicyName.java 100.00% <100.00%> (ø)
...g/apache/pulsar/common/policies/data/Policies.java 56.98% <33.33%> (-0.16%) ⬇️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 91.39% <82.35%> (+22.29%) ⬆️
...sar/broker/service/persistent/PersistentTopic.java 79.32% <89.65%> (+0.86%) ⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 64.40% <42.85%> (+0.36%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 76.78% <86.66%> (+3.70%) ⬆️

... and 360 files with indirect coverage changes

# Conflicts:
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
@Demogorgon314
Copy link
Member

@gaoran10 @Technoboy- Please help review this PR.

@Technoboy- Technoboy- merged commit 36bae69 into apache:master Jun 20, 2024
48 of 51 checks passed
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Jun 24, 2024
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Jun 24, 2024
Technoboy- pushed a commit that referenced this pull request Jun 26, 2024
…el (#22378) (#22961)

Co-authored-by: Xiangying Meng <55571188+liangyepianzhou@users.noreply.github.com>
Demogorgon314 added a commit that referenced this pull request Jul 1, 2024
…amespace level (#22378) (#22960)

(cherry-picked from commit 36bae69)
Co-authored-by: Xiangying Meng <55571188+liangyepianzhou@users.noreply.github.com>
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
…amespace level (apache#22378) (apache#22960)

(cherry-picked from commit apache@36bae69)
Co-authored-by: Xiangying Meng <55571188+liangyepianzhou@users.noreply.github.com>

(cherry picked from commit 7b2e724)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
…amespace level (apache#22378) (apache#22960)

(cherry-picked from commit apache@36bae69)
Co-authored-by: Xiangying Meng <55571188+liangyepianzhou@users.noreply.github.com>

(cherry picked from commit 7b2e724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants