[fix][storage] ReadonlyManagedLedger initialization does not fill in the properties #22630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanyao
changed the title
nodece
reviewed
May 2, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ReadOnlyManagedLedgerImpl.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
May 3, 2024
|
/pulsarbot rerun-failure-checks |
2 similar comments
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22630 +/- ##
============================================
- Coverage 73.57% 72.74% -0.83%
+ Complexity 32624 2418 -30206
============================================
Files 1877 1887 +10
Lines 139502 141010 +1508
Branches 15299 15480 +181
============================================
- Hits 102638 102581 -57
- Misses 28908 30569 +1661
+ Partials 7956 7860 -96
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dao-jun
approved these changes
May 3, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2024
…the properties (apache#22630) (cherry picked from commit eee3694) (cherry picked from commit 91f4287)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…the properties (apache#22630) (cherry picked from commit eee3694) (cherry picked from commit 91f4287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22606
Main Issue: ReadonlyManagedLedger initialization does not fill in the properties.
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: