Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Add the missed opentelemetry-sdk-testing dependency to tests of pulsar-broker-auth-sasl #22665

Merged

Conversation

BewareMyPower
Copy link
Contributor

Fixes #22664

After importing the dependency, tests of pulsar-broker-auth-sasl can run now.

image
$ mvn test -pl pulsar-broker-auth-sasl -Dtest='ProxySaslAuthenticationTest'
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.28 s - in org.apache.pulsar.broker.authentication.ProxySaslAuthenticationTest

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@BewareMyPower BewareMyPower self-assigned this May 7, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 7, 2024
@BewareMyPower BewareMyPower added type/bug The PR fixed a bug or issue reported a bug area/broker and removed doc-not-needed Your PR changes do not impact docs labels May 7, 2024
@BewareMyPower BewareMyPower added this to the 3.3.0 milestone May 7, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 7, 2024
@BewareMyPower BewareMyPower requested a review from coderzc May 7, 2024 11:56
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 519d8e2 into apache:master May 7, 2024
51 of 56 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/add-otel-to-sasl branch May 8, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to run tests in the pulsar-broker-auth-sasl module
3 participants