[improve][broker] Clear thread local BrokerEntryMetadata instance before reuse #22752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/cleanup
dao-jun
approved these changes
May 21, 2024
nodece
approved these changes
May 21, 2024
Demogorgon314
approved these changes
May 21, 2024
Technoboy-
approved these changes
May 22, 2024
Technoboy-
pushed a commit
that referenced
this pull request
May 30, 2024
Technoboy-
pushed a commit
that referenced
this pull request
May 30, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 31, 2024
…ore reuse (apache#22752) (cherry picked from commit 18db799)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…ore reuse (apache#22752) (cherry picked from commit 18db799)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…ore reuse (apache#22752) (cherry picked from commit 18db799)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…ore reuse (apache#22752) (cherry picked from commit 18db799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BROKER_ENTRY_METADATA is a thread local that contains the reused BrokerEntryMetadata instance.
It should be cleared before reusing.
Modifications
.clear()before reusing the instance.Documentation
docdoc-requireddoc-not-neededdoc-complete