Add Flink - Pulsar Batch Sink Support #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
sijie
requested changes
Nov 13, 2018
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { |
There was a problem hiding this comment.
close the producer when the output format is closed?
There was a problem hiding this comment.
@sijie Thanks for the review this.
This is the my concern as well. However, afais in local tests, close is called multiple times and causing to be closed the Producer before submitting all batch.
|
|
||
| private transient Function<Throwable, MessageId> failureCallback; | ||
|
|
||
| private static volatile Producer<byte[]> producer; |
There was a problem hiding this comment.
any reason why you make it static?
There was a problem hiding this comment.
As same with close function, open function is also called multiple times. To avoid multiple Producer instance creation, it needs to be singleton at class level so it is static.
erenavsarogullari
force-pushed
the
PulsarPR_FlinkBatchSinkSupport
branch
from
2f8cafb
to
c3140d5
Compare
sijie
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to bring Flink - Pulsar
Batch SinkSupport. If user works with FlinkDataSetAPI and would like to write theseDataSetsto Pulsar, this sink can help.Ref: Flink Batch Sink API
Modifications
Please find the change-set as follows:
PulsarOutputFormatto write Flink BatchDataSetsinto Pulsar.FlinkPulsarBatchSinkExampleto show how to use and to be used by users.README.mddocumentationjavadocfix