Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate pulsar client API interfaces in different module #3309

Merged
merged 7 commits into from
Jan 9, 2019
Merged

Separate pulsar client API interfaces in different module #3309

merged 7 commits into from
Jan 9, 2019

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jan 6, 2019

Motivation

Isolating the API into a separate module will achieve:

  • Clear separation from implementation. No referencing by mistake impl classes from public API
  • Avoid shading issue. API module has no dependencies
  • Attached Javadoc and Sources. Artifacts published in Maven central will include Javadoc and sources jar, so that from IDE user can access the API documentation. This is currently not working because of the shading plugin. Fixes Add Maven Source Plugin. #2622

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jan 6, 2019
@merlimat merlimat added this to the 2.3.0 milestone Jan 6, 2019
@merlimat merlimat self-assigned this Jan 6, 2019
@merlimat
Copy link
Contributor Author

merlimat commented Jan 7, 2019

run integration tests

@merlimat merlimat merged commit 918dc68 into apache:master Jan 9, 2019
@merlimat merlimat deleted the separate-api-from-impl-2 branch January 9, 2019 15:30
@merlimat merlimat mentioned this pull request Feb 14, 2019
Closed
@sijie sijie mentioned this pull request Mar 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrypeng jerrypeng jerrypeng approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@merlimat merlimat

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @jerrypeng