[pulsar-client-go]add producer.LastSequenceID and message SequenceID in Go client #3416
Conversation
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
pulsar-client-go/pulsar/producer.go
Outdated
| @@ -163,6 +163,14 @@ type Producer interface { | |||
| // the eventual error in publishing | |||
| SendAsync(context.Context, ProducerMessage, func(ProducerMessage, error)) | |||
|
|
|||
| // Get the last sequence id that was published by this producer. | |||
| // This represent either the automatically assigned or custom sequence id (set on the MessageBuilder) that | |||
There was a problem hiding this comment.
Instead of MessageBuilder which is in Java client lib, we should refer to ProducerMessage here (https://github.com/apache/pulsar/blob/master/pulsar-client-go/pulsar/message.go#L24)
There was a problem hiding this comment.
Also, the ProducerMessage doesn't currently have a way to specify the sequence id of a particular message. This should be done by using pulsar_message_set_sequence_id() function.
There was a problem hiding this comment.
yes, you are reight. I will provide this interface to achieve the corresponding function in next pull request.
merlimat
added
type/feature
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
PTAL @merlimat thanks |
pulsar-client-go/pulsar/message.go
Outdated
| @@ -36,6 +36,9 @@ type ProducerMessage struct { | |||
|
|
|||
| // Override the replication clusters for this message. | |||
| ReplicationClusters []string | |||
|
|
|||
| // Set the sequence id to assign to the current message | |||
| ID int64 | |||
There was a problem hiding this comment.
I would use SequenceID here to avoid confusion with the "MessageId" concept which is different. eg. On a received message, Message.ID() will give you the MessageId (assigned by brokers) rather than the sequence id (assigned by producer).
There was a problem hiding this comment.
At the same time, I think we should also expose a way to retrieve the sequence id on a received message as in Message.SequenceID() method.
There was a problem hiding this comment.
yes, SequenceID sounds good. About Message.SequenceID() method, i will provide in the next pull request.
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
wolfstudy
changed the title
|
@merlimat PTAL again |
|
run java8 tests |
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Motivation
Add producer.LastSequenceID and message SequenceID in Go client.