[go client] add SubscriptionInitPos option in ConsumerOptions #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
merlimat
reviewed
Feb 13, 2019
| @@ -77,6 +86,9 @@ type ConsumerOptions struct { | |||
| // Default is `Exclusive` | |||
| Type SubscriptionType | |||
|
|
|||
| // Default is `Latest` | |||
There was a problem hiding this comment.
Comment should indicate what is the purpose of setting a SubscriptionInitPos, eg: "If the subscription does not exist, it will be created either pointing at the end of the topic (Latest, which is the default) or on the earliest available message Earliest)"
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
thanks for your help @merlimat PTAL again. |
merlimat
added
type/feature
|
run cpp tests |
|
run cpp tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Fixes #3494
Motivation
[go client] add SubscriptionInitPos option in ConsumerOptions