Negative acks in C++ client #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/feature
|
rerun java8 tests |
Yes, I have pending PRs for Python and Go that depend on this one |
sijie
approved these changes
Mar 6, 2019
| * @return the consumer builder instance | ||
| */ | ||
| void setNegativeAckRedeliveryDelayMs(long redeliveryDelayMillis); | ||
| long getNegativeAckRedeliveryDelayMs() const; |
| * The {@code Message} to be acknowledged | ||
| */ | ||
| void pulsar_consumer_negative_acknowledge(pulsar_consumer_t *consumer, pulsar_message_t *message); | ||
| void pulsar_consumer_negative_acknowledge_id(pulsar_consumer_t *consumer, pulsar_message_id_t *messageId); |
| */ | ||
| void pulsar_configure_set_negative_ack_redelivery_delay_ms( | ||
| pulsar_consumer_configuration_t *consumer_configuration, long redeliveryDelayMillis); | ||
| long pulsar_configure_get_negative_ack_redelivery_delay_ms( |
jai1
reviewed
Mar 6, 2019
| @@ -99,7 +100,7 @@ static void sendCallBackWithDelay(Result r, const Message& msg, std::string pref | |||
|
|
|||
| class EncKeyReader : public CryptoKeyReader { | |||
| private: | |||
| void readFile(std::string fileName, std::string& fileContents) const { | |||
| void readFile(std::string fileName, std::string &fileContents) const { | |||
There was a problem hiding this comment.
This is existing code and it was just one space reformatted by make format.
In any case the functional change should be done in a different PR. Given this is for test, I'm not particular concerned about a string copy when loading the key file.
jai1
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
Are we keeping https://github.com/apache/pulsar/projects/7 updated?
|
rerun java8 tests |
This was referenced Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to #3703, adding support for negative Acks in C++ client (and C wrapper)