Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative acks implementation for Go client #3817

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Negative acks implementation for Go client #3817

merged 1 commit into from
Mar 14, 2019

Conversation

merlimat
Copy link
Contributor

Motivation

Added Go bindings for "Negative acks" implemented in C++ #3750

@merlimat merlimat added type/feature The PR added a new feature or issue requested a new feature component/go labels Mar 13, 2019
@merlimat merlimat added this to the 2.4.0 milestone Mar 13, 2019
@merlimat merlimat self-assigned this Mar 13, 2019
@wolfstudy
Copy link
Member

LGTM

@wolfstudy
Copy link
Member

run java8 tests

1 similar comment
@jiazhai
Copy link
Member

jiazhai commented Mar 14, 2019

run java8 tests

@merlimat merlimat merged commit c83631b into apache:master Mar 14, 2019
@merlimat merlimat deleted the nacks-go branch March 14, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@merlimat merlimat

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@merlimat @wolfstudy @jiazhai