fix: ack timeout in pulsar cpp client when subscribing to regex topic #3879
Conversation
|
@merlimat i have added a test |
| @@ -2940,3 +2940,50 @@ TEST(BasicEndToEndTest, testPreventDupConsumersAllowSameSubForDifferentTopics) { | |||
| // consumer C should be a different instance from A and B and should be with open state. | |||
| ASSERT_EQ(ResultOk, consumerC.close()); | |||
| } | |||
|
|
|||
| static long regexTestMessagesReceived = 0; | |||
There was a problem hiding this comment.
This gets updated from one thread and read from another. We should use std::atomic<long>
There was a problem hiding this comment.
I can but does it really matter since its only one writer? Also we doing the same thing in a couple places:
https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/tests/BasicEndToEndTest.cc#L47
There was a problem hiding this comment.
Yes, the number will be correct because of the single writer, but the reader is technically not guaranteed to see the latest value. Though, yes, with sleep and retries it would settle anyway.
| if (regexTestMessagesReceived >= 10 * 2) { | ||
| break; | ||
| } | ||
| usleep(500000); |
There was a problem hiding this comment.
unistd.h is only posix specific. std::this_thread::sleep is the preferred c++ 11 way to sleep
|
rerun java8 tests |
|
rerun java8 tests |
|
rerun java8 tests |
|
rerun java8 tests |
Motivation
When subscribing to a regex in cpp/python client and using a message listener, ack timeout does work and unacked messages are not delivered.
This is because the unack message tracker is not call in one place