Reduce memory used in ClientCnx for pending lookups #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
jerrypeng
reviewed
Apr 22, 2019
| this.waitingLookupRequests = Queues | ||
| .newArrayBlockingQueue((conf.getMaxLookupRequest() - conf.getConcurrentLookupRequest())); | ||
| this.pendingLookupRequestSemaphore = new Semaphore(conf.getConcurrentLookupRequest(), false); | ||
| this.maxLookupRequestSemaphore = new Semaphore(conf.getMaxLookupRequest(), false); |
There was a problem hiding this comment.
conf.getMaxLookupRequest() - conf.getConcurrentLookupRequest()
jerrypeng
approved these changes
Apr 22, 2019
rdhabalia
approved these changes
Apr 22, 2019
jiazhai
approved these changes
Apr 23, 2019
MarvinCai
added a commit
to MarvinCai/pulsar
that referenced
this pull request
May 16, 2019
Update to use ConcurrentLinkedQueue and same semaphore to limit concurrent request for BatchLookRequest. It share same semaphore with normal lookup request.
MarvinCai
added a commit
to MarvinCai/pulsar
that referenced
this pull request
May 17, 2019
Update to use ConcurrentLinkedQueue and same semaphore to limit concurrent request for BatchLookRequest. It share same semaphore with normal lookup request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, each
ClientCnxhas a blocking queue for the max number of pending lookup requests. By default that ends up using an array of 45K objects. When a single process handles many connections (eg: broker or proxy), that will end up using 200K per connection just for this.Modifications
Instead of using the fixed array size, use semaphore and a
ConcurrentLinkedQueue