Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1 #4181

Merged
merged 1 commit into from
May 3, 2019
Merged

AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1 #4181

merged 1 commit into from
May 3, 2019

Conversation

sijie
Copy link
Member

@sijie sijie commented Apr 30, 2019

Motivation

AlwaysCompatible flag doesn't work in 2.3.1 because the flag is using NeverSchemaValidator

Modifications

Change to use AlwaysSchemaValidator

@sijie
AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1
5c1a292 
*Motivation*

AlwaysCompatible flag doesn't work in 2.3.1 because the flag is using NeverSchemaValidator

*Modifications*

Change to use AlwaysSchemaValidator
@sijie sijie added type/bug The PR fixed a bug or issue reported a bug component/schemaregistry labels Apr 30, 2019
@sijie sijie added this to the 2.3.2 milestone Apr 30, 2019
@sijie sijie self-assigned this Apr 30, 2019
@sijie
Copy link
Member Author

sijie commented Apr 30, 2019

/cc @shiv4289

@sijie
Copy link
Member Author

sijie commented Apr 30, 2019

I see why this change is not cherry-picked to 2.3.1. Because there was a refactored in 2.4.0 which refactor the JSON and AVRO schema compatibility check logic into a AvroSchemaBasedCompatibilityCheck. so when the change is cherry-picked from master to 2.3.1, I guess the change was dropped somehow.

@shiv4289
Copy link
Contributor

/cc @shiv4289

Thanks for the quick response @sijie . Very helpful :-)

merlimat
merlimat approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat
Copy link
Contributor

merlimat commented May 2, 2019

run java8 tests
run integration tests

@aahmed-se
Copy link
Contributor

run java8 tests

@sijie sijie merged commit bb21790 into apache:branch-2.3 May 3, 2019
@sijie sijie deleted the fix_always_compatible_bug branch May 3, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@aahmed-se aahmed-se aahmed-se approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@sijie sijie

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sijie @shiv4289 @merlimat @aahmed-se @codelipenghui