Avoid payload copy when inserting into managed ledger cache #4197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #4066, we now have a strict upper bound for the time spent in cache by entries. Since this was the principal reason to make a copy when inserting into the cache, we can now avoid that data copy and just increment the refcount on the same buffer.
Leaving it as an option to fallback to the original behavior, just in case there is any unforeseen regression in behavior under particular conditions.