[pulsar-broker] add support of secondary bookie-isolation-group #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
reviewed
May 13, 2019
| @@ -353,4 +353,53 @@ public void testOverlappedBookies() throws Exception { | |||
|
|
|||
| localZkc.delete(ZkBookieRackAffinityMapping.BOOKIE_INFO_ROOT_PATH, -1); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSecondaryIsolationGroupsBookies() throws Exception { | |||
There was a problem hiding this comment.
This test looks great. How about also adding a negative test, that test without secondaryIsolatedBookieGroup configured newEnsemble will fail for no enough bookie?
|
@jiazhai added -ve test. |
|
rerun integration tests |
|
rerun integration tests |
1 similar comment
|
rerun integration tests |
merlimat
added
the
type/enhancement
sijie
pushed a commit
that referenced
this pull request
Jan 18, 2020
### Motivation Some parameters are added in the `broker.conf` and `standalone.conf` files. However, those parameters are not updated in the docs. See the following PRs for details: #4150, #4066, #4197, #3819, #4261, #4273, #4320. ### Modifications Add those parameter info, and sync docs with the code. Does not update the description quite much, there are two reasons for this: 1. Keep doc content consistent with code. We need to update the description for those parameters in the code first, and then sync them in docs. 2. Will adopt a generator to generate those content automatically in the near future.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Some parameters are added in the `broker.conf` and `standalone.conf` files. However, those parameters are not updated in the docs. See the following PRs for details: apache#4150, apache#4066, apache#4197, apache#3819, apache#4261, apache#4273, apache#4320. ### Modifications Add those parameter info, and sync docs with the code. Does not update the description quite much, there are two reasons for this: 1. Keep doc content consistent with code. We need to update the description for those parameters in the code first, and then sync them in docs. 2. Will adopt a generator to generate those content automatically in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While using bookie-isolation group in broker, sometimes, isolated bookies became unavailable due to bookie goes down and that causes write failure on that broker. So, we need secondary bookie-isolation policy where broker can fallback to secondary bookies if primary groups don't have enough bookies available.