Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate admin operation on topic with authoritative parameter #4270

Merged

Conversation

liketic
Copy link
Contributor

@liketic liketic commented May 13, 2019

The parameter authoritative is not used which should be passed to validateAdminOperationOnTopic, otherwise we should remove it.

Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat
Copy link
Contributor

run integration tests
run java8 tests

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label May 15, 2019
@merlimat merlimat added this to the 2.3.2 milestone May 15, 2019
@merlimat
Copy link
Contributor

run java8 tests

1 similar comment
@merlimat
Copy link
Contributor

run java8 tests

@merlimat merlimat merged commit e77d0b1 into apache:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants