Added support for Snappy compression for Python/Go #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run cpp tests |
sijie
approved these changes
May 21, 2019
sijie
added
area/client
component/go
type/feature
|
run cpp tests |
|
We should have a graceful fallback if C++ lib is not compiled with Snappy, returning an error when we try to create a producer. |
|
@murong00 can you merge to latest master to include a pip fix in integration test? |
|
run integration tests |
merlimat
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in #4259, this PR try to support Snappy compression (https://google.github.io/snappy/) for Python/Go.