Fix remove pending acks in Key_Shared subscription #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wolfstudy Thank you very much for discovering this problem in time. Please review the changes. |
jiazhai
approved these changes
May 30, 2019
|
run Java8 Tests |
|
LGTM +1 |
merlimat
reviewed
May 30, 2019
| @@ -334,7 +334,7 @@ void messageAcked(CommandAck ack) { | |||
| return; | |||
| } | |||
|
|
|||
| if (subType == SubType.Shared) { | |||
| if (subType == SubType.Shared || subType == SubType.Key_Shared) { | |||
There was a problem hiding this comment.
Since this is being checked multiple times, we could have a static method to check for this condition
There was a problem hiding this comment.
Exactly this is being checked multiple times, i'm already add static method named Subscription.isIndividualAckMode(), PTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix remove pending acks in Key_Shared subscription and some other stats issue of Key_Shared subscription
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation