Support key-shared subscribe mode for go client #4465
Conversation
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
| @@ -156,7 +156,7 @@ func createProducerAsync(client *client, schema Schema, options ProducerOptions, | |||
| C._pulsar_producer_configuration_set_message_router(conf, savePointer(&options.MessageRouter)) | |||
| } | |||
|
|
|||
| if options.Batching { | |||
| if !options.Batching { | |||
There was a problem hiding this comment.
Maybe we should not depends on default values
pulsar-client-go/pulsar/consumer.go
Outdated
|
|
||
| // Multiple consumer will be able to use the same subscription and all messages with the same key | ||
| // will be dispatched to only one consumer | ||
| keyShared |
There was a problem hiding this comment.
This should be start with capital letter too, like Exclusive and Failover
There was a problem hiding this comment.
yes, should is KeyShared
pulsar-client-go/pulsar/consumer.go
Outdated
|
|
||
| // Multiple consumer will be able to use the same subscription and all messages with the same key | ||
| // will be dispatched to only one consumer | ||
| keyShared |
There was a problem hiding this comment.
Should k be capitalized here? otherwise it's private to the package right?
There was a problem hiding this comment.
Thank you for reminding me.
| @@ -156,7 +156,7 @@ func createProducerAsync(client *client, schema Schema, options ProducerOptions, | |||
| C._pulsar_producer_configuration_set_message_router(conf, savePointer(&options.MessageRouter)) | |||
| } | |||
|
|
|||
| if options.Batching { | |||
| if !options.Batching { | |||
There was a problem hiding this comment.
This is a different issue which we should address separately. The main issue is that batching is just a flag, so there's no way to know wether the user touched it or not (eg: it should have been a *bool instead).
There was a problem hiding this comment.
In cpp client, the default value of batch is true. So, only when batch is false, the user need to set it up.
(eg: it should have been a
*boolinstead)
yes, use this way, we can know wether the user touched it or not, by:
if options.Batching !=nil {
...
}
but the effect between them is the same.
When using it, I think users prefer to use it this way:
producer, err := client.CreateProducer(ProducerOptions{
Topic: topic,
Batching: false,
})
Instead of:
var flag = false
producer, err := client.CreateProducer(ProducerOptions{
Topic: topic,
Batching: &flag,
})
So, I don't think we need to care wether the user has batch here.
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
wolfstudy
changed the title
|
I removed the batch-related logic from the current pull request and modified the logic in a new pull request. PTAL thanks. Before you merge the current pull request, please merge pull/4475 |
|
run java8 tests |
wolfstudy
changed the title
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Motivation
Support key-shared subscribe mode for go client