Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tests in the presto module #4683

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Cleanup tests in the presto module #4683

merged 2 commits into from
Jul 8, 2019

Conversation

vzhikserg
Copy link
Contributor

Modifications

Cleanup in the presto module which includes the following changes:

  • Use the preferred way of the schema's creation.
  • Predicates and Functions were converted to lambda
  • Add static import statements for Assert to improve the readability of the tests

@vzhikserg vzhikserg changed the title Cleanup presto Cleanup tests in the presto module Jul 7, 2019
@jiazhai jiazhai requested a review from jerrypeng July 8, 2019 02:27
@jiazhai jiazhai assigned jiazhai and vzhikserg and unassigned jiazhai Jul 8, 2019
@jiazhai jiazhai added the area/sql Pulsar SQL related features label Jul 8, 2019
@jiazhai jiazhai added this to the 2.5.0 milestone Jul 8, 2019
@jiazhai
Copy link
Member

jiazhai commented Jul 8, 2019

run cpp tests
run integration tests

jiazhai
jiazhai approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vzhikserg for the work. lgtm

@merlimat merlimat merged commit c421ca6 into apache:master Jul 8, 2019
easyfan pushed a commit to easyfan/pulsar that referenced this pull request Jul 26, 2019
@vzhikserg @easyfan
Cleanup tests in the presto module (apache#4683)
121366a 
* Add static import statements for Assert to simplify the test in the presto module

* Use the preferred way of the schema's creation. The predicates and functions were converted to lambda
@jiazhai jiazhai modified the milestones: 2.5.0, 2.4.1 Aug 27, 2019
@jiazhai
Copy link
Member

jiazhai commented Aug 27, 2019

mark 2.4.1, for conflict with #4736

jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@vzhikserg @jiazhai
Cleanup tests in the presto module (#4683)
2c97da5 
* Add static import statements for Assert to simplify the test in the presto module

* Use the preferred way of the schema's creation. The predicates and functions were converted to lambda

(cherry picked from commit c421ca6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@jerrypeng jerrypeng jerrypeng approved these changes

@jiazhai jiazhai jiazhai approved these changes

Assignees

@vzhikserg vzhikserg

Labels
area/sql Pulsar SQL related features area/test
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vzhikserg @jiazhai @merlimat @jerrypeng