-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue:4726] Fix the problem that the log folder in pulsa-function-go
is ignored
#4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
pulsa-function-go
is ignored bypulsa-function-go
is ignored
Thanks @freeznet for pointing this out, PTAL. |
sijie
approved these changes
Jul 16, 2019
run java8 tests |
run integration tests |
2 similar comments
run integration tests |
run integration tests |
run java8 tests |
run java8 tests |
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
apache#4736) Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Fixes #4726
Motivation
We repackaged the
logrus
log library and named itlog
. But at .gitignore#L37, we ignored alllog
files. The log file inpulsar-function-go
is not uploaded.In
pulsar-function-go
, the log file is the key to implementing thelogtopic
function, we can't ignore it. So this pull request renames thelog
tologutil
to avoid this problem.