Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : retention size policy bug #4825

Merged
merged 10 commits into from
Aug 1, 2019

Conversation

fxbing
Copy link
Contributor

@fxbing fxbing commented Jul 26, 2019

the 0 size limit can't means "infinite" size quota

@fxbing
Copy link
Contributor Author

fxbing commented Jul 26, 2019

run java8 tests

2 similar comments
@fxbing
Copy link
Contributor Author

fxbing commented Jul 27, 2019

run java8 tests

@fxbing
Copy link
Contributor Author

fxbing commented Jul 27, 2019

run java8 tests

@fxbing fxbing force-pushed the fix-retentionSize-policy-bug branch from f561dc4 to 0e2a338 Compare July 27, 2019 15:11
@sijie sijie added area/admin type/bug The PR fixed a bug or issue reported a bug labels Jul 29, 2019
@sijie sijie added this to the 2.4.1 milestone Jul 29, 2019
Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@sijie sijie merged commit 77f6370 into apache:master Aug 1, 2019
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
the 0 size limit can't means "infinite" size quota
(cherry picked from commit 77f6370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants