Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 4956]Add default loader for latest pyyaml #4974

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Aug 18, 2019

Fixes #4956

Master Issue: #4956

Motivation

In the latest version of pyyaml, using load will issue a warning and explain some reasons here https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation.

Modifications

  • Use yaml.FullLoader as default loader

@tuteng tuteng changed the title Add default loader for latest pyyaml [Issue 4956]Add default loader for latest pyyaml Aug 18, 2019
@sijie sijie added this to the 2.4.1 milestone Aug 18, 2019
@sijie
Copy link
Member

sijie commented Aug 18, 2019

run cpp tests

4 similar comments
@sijie
Copy link
Member

sijie commented Aug 18, 2019

run cpp tests

@tuteng
Copy link
Member Author

tuteng commented Aug 18, 2019

run cpp tests

@sijie
Copy link
Member

sijie commented Aug 18, 2019

run cpp tests

@sijie
Copy link
Member

sijie commented Aug 19, 2019

run cpp tests

@sijie sijie merged commit d49e61e into apache:master Aug 19, 2019
@sijie sijie deleted the fix/pyyaml-waring branch August 19, 2019 11:25
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
Fixes #4956

Master Issue: #4956

### Motivation

In the latest version of pyyaml, using load will issue a warning and explain some reasons here https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation.

### Modifications

* Use yaml.FullLoader as default loader

(cherry picked from commit d49e61e)
jerrypeng added a commit that referenced this pull request Oct 21, 2019
tuteng pushed a commit that referenced this pull request Oct 22, 2019
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
This reverts commit d49e61e.

(cherry picked from commit c4035d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gen-yml-from-env.py is broken in 2.4.0
2 participants