[Pulsar-sql]Using pulsar SQL query messages will appear NoSuchLedger when zk root directory changed
#5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sijie I think the integration tests is more suit for testing this scene. But I need to change the test framework to make zookeeper URI configurable and then move to the specified path, for example, 127.0.0.1:2181/pulsar, to test it is working well. Do you have any suggestions? |
|
@zymap managed ledger has a lot of tests there. why not add one test there? also the point here is to have tests for any code you add or modify in Pulsar. |
|
@zymap As Sijie suggested we could add tests for ManagedLedger firstly, this would cover most of the code changes. |
…ot directory changed --- Fixes apache#4715 *Motivation* When zookeeper ledgers root path is changed, using pulsar-sql to query messages will cause `BKNoSuchLedgerExistsException`. *Modifications* Make bookie using `setMetadataServiceUri` to set zookeeper uri
|
@zymap this pull request has been outstanding for a few months. Can you address the comments? |
|
@sijie Ok |
zymap
force-pushed
the
presto-prefix-name
branch
from
d681d87
to
cf8a50e
Compare
zymap
force-pushed
the
presto-prefix-name
branch
from
cf8a50e
to
981a4dd
Compare
sijie
approved these changes
Nov 26, 2019
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Jun 4, 2020
Fixes #6852 ### Motivation Currently, if the config `pulsar.zookeeper-uri` use multi zk address like this `127.0.0.1:2181,127.0.0.2:2181,127.0.0.3:2181` in $PULAR_HOME/conf/presto/catalog/pulsar.properties, the Pulsar SQL query will be failed. Break PR #5001. ### Modifications Change the multi zk address delimiter from `,` to `;` for the config `metadataServiceUri` of the `ClientConfiguration`.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#6852 ### Motivation Currently, if the config `pulsar.zookeeper-uri` use multi zk address like this `127.0.0.1:2181,127.0.0.2:2181,127.0.0.3:2181` in $PULAR_HOME/conf/presto/catalog/pulsar.properties, the Pulsar SQL query will be failed. Break PR apache#5001. ### Modifications Change the multi zk address delimiter from `,` to `;` for the config `metadataServiceUri` of the `ClientConfiguration`.
sijie
pushed a commit
to apache/pulsar-presto
that referenced
this pull request
Nov 11, 2020
Fixes #6852 ### Motivation Currently, if the config `pulsar.zookeeper-uri` use multi zk address like this `127.0.0.1:2181,127.0.0.2:2181,127.0.0.3:2181` in $PULAR_HOME/conf/presto/catalog/pulsar.properties, the Pulsar SQL query will be failed. Break PR apache/pulsar#5001. ### Modifications Change the multi zk address delimiter from `,` to `;` for the config `metadataServiceUri` of the `ClientConfiguration`.
sijie
pushed a commit
to apache/pulsar-presto
that referenced
this pull request
Nov 11, 2020
Fixes #6852 ### Motivation Currently, if the config `pulsar.zookeeper-uri` use multi zk address like this `127.0.0.1:2181,127.0.0.2:2181,127.0.0.3:2181` in $PULAR_HOME/conf/presto/catalog/pulsar.properties, the Pulsar SQL query will be failed. Break PR apache/pulsar#5001. ### Modifications Change the multi zk address delimiter from `,` to `;` for the config `metadataServiceUri` of the `ClientConfiguration`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4715
Motivation
When zookeeper ledgers root path is changed, using pulsar-sql to query messages will cause
BKNoSuchLedgerExistsException.Modifications
Make bookie using
setMetadataServiceUrito set zookeeper uri.