[Pulsar SQL] Fix pulsar sql use multi zk address failed #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
changed the title
sijie
added
area/sql
sijie
approved these changes
May 18, 2020
codelipenghui
approved these changes
May 19, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#6852 ### Motivation Currently, if the config `pulsar.zookeeper-uri` use multi zk address like this `127.0.0.1:2181,127.0.0.2:2181,127.0.0.3:2181` in $PULAR_HOME/conf/presto/catalog/pulsar.properties, the Pulsar SQL query will be failed. Break PR apache#5001. ### Modifications Change the multi zk address delimiter from `,` to `;` for the config `metadataServiceUri` of the `ClientConfiguration`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6852
Motivation
Currently, if the config
pulsar.zookeeper-uriuse multi zk address like this127.0.0.1:2181,127.0.0.2:2181,127.0.0.3:2181in $PULAR_HOME/conf/presto/catalog/pulsar.properties, the Pulsar SQL query will be failed.Break PR #5001.
Modifications
Change the multi zk address delimiter from
,to;for the configmetadataServiceUriof theClientConfiguration.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation