Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update *Overview of Connector* #5183

Merged
merged 2 commits into from
Sep 17, 2019
Merged

[Doc] Update *Overview of Connector* #5183

merged 2 commits into from
Sep 17, 2019

Conversation

Anonymitaet
Copy link
Member

Fix #5015

Anonymitaet
Anonymitaet commented Sep 12, 2019
View reviewed changes
site2/docs/io-overview.md Outdated

Pulsar connectors are **special** [Pulsar Functions](functions-overview.md) built to interact with external systems.

Sources, sinks, and Functions are components of instances, and they all run on Functions workers. When managing sources, sinks or Functions via **Pulsar admin CLI** (that is, [Connector CLI](reference-connector-admin.md) and [Functions CLI](functions-cli.md)), an instance is started on a worker.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng could you please provide more technical inputs about the relationship between connectors and Functions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no necessary relationship between connectors and functions. The relationship between connectors and function worker can be referred to this figure http://pulsar.apache.org/docs/en/functions-worker/#run-functions-worker-separately.

@Anonymitaet Anonymitaet mentioned this pull request Sep 12, 2019
Closed
Anonymitaet
Anonymitaet commented Sep 12, 2019
View reviewed changes
Copy link
Member Author

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng could you please help review? Thank you

@Jennifer88huang-zz Jennifer88huang-zz added component/connect doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 12, 2019
@Jennifer88huang-zz Jennifer88huang-zz added this to the 2.5.0 milestone Sep 12, 2019
tuteng
tuteng reviewed Sep 14, 2019
View reviewed changes
site2/docs/io-overview.md Outdated

Pulsar connectors are **special** [Pulsar Functions](functions-overview.md) built to interact with external systems.

Sources, sinks, and Functions are components of instances, and they all run on Functions workers. When managing sources, sinks or Functions via **Pulsar admin CLI** (that is, [Connector CLI](reference-connector-admin.md) and [Functions CLI](functions-cli.md)), an instance is started on a worker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no necessary relationship between connectors and functions. The relationship between connectors and function worker can be referred to this figure http://pulsar.apache.org/docs/en/functions-worker/#run-functions-worker-separately.

site2/docs/io-overview.md Outdated

Pulsar connectors are **special** [Pulsar Functions](functions-overview.md) built to interact with external systems.

Sources, sinks, and Functions are components of instances, and they all run on Functions workers. When managing sources, sinks or Functions via **Pulsar admin CLI** (that is, [Connector CLI](reference-connector-admin.md) and [Functions CLI](functions-cli.md)), an instance is started on a worker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sources, sinks or Functions does the first letter have to be uppercase or lowercase?

@Anonymitaet
Copy link
Member Author

@tuteng I've incorporated all your comments, could you PTAL?

@Anonymitaet
Copy link
Member Author

run integration tests

@Anonymitaet
Copy link
Member Author

run java8 tests

1 similar comment
@Anonymitaet
Copy link
Member Author

run java8 tests

@sijie sijie merged commit 26df3e7 into apache:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@tuteng tuteng tuteng approved these changes

Assignees

@Anonymitaet Anonymitaet

Labels
area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

[Doc] Update Pulsar Connector Guide
5 participants
@Anonymitaet @sijie @tuteng @tisonkun @Jennifer88huang-zz