[Issue #5176][pulsar-broker] Fix bug that fails to search namespace bundle due to NPE #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Sep 14, 2019
|
run java8 tests |
|
rerun java8 tests |
2 similar comments
|
rerun java8 tests |
|
rerun java8 tests |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
Fixes #5176 ### Motivation As mentioned in #5176, NPE may occur in the load manager and fail to search for namespace bundles. This is because multiple threads may update a map named `brokerToNamespaceToBundleRange` at the same time. ### Modifications - Changed `brokerToNamespaceToBundleRange` to ConcurrentOpenHashMap instead of HashMap which is not thread safe. - Fixed `LoadManagerShared.removeMostServicingBrokersForNamespace()` logic so that NPE does not occur. (cherry picked from commit 412c8fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5176
Motivation
As mentioned in #5176, NPE may occur in the load manager and fail to search for namespace bundles. This is because multiple threads may update a map named
brokerToNamespaceToBundleRangeat the same time.Modifications
brokerToNamespaceToBundleRangeto ConcurrentOpenHashMap instead of HashMap which is not thread safe.LoadManagerShared.removeMostServicingBrokersForNamespace()logic so that NPE does not occur.