Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-broker] fix ns-isolation api to fetch policy for specific broker #5314

Merged
merged 1 commit into from
Oct 7, 2019
Merged

[pulsar-broker] fix ns-isolation api to fetch policy for specific broker #5314

merged 1 commit into from
Oct 7, 2019

Conversation

rdhabalia
Copy link
Contributor

Motivation

Right now,
./pulsar-admin ns-isolation-policy broker <cluster> --broker <broker-name> is broken because broker incorrectly validates broker:

  • broker validates that given broker is part of availableBroker list which is unnecessary and incorrect because availableBroker contains broker:port which will always fail the validation and this command never gives any correct result.

Modification

  • remove unnecessary validation
  • add more ns-isolation data into response. eg: policyName and isPrimary broker.

@rdhabalia rdhabalia added this to the 2.5.0 milestone Oct 4, 2019
@rdhabalia rdhabalia self-assigned this Oct 4, 2019
@rdhabalia
Copy link
Contributor Author

retest this please

@merlimat merlimat merged commit e1357a7 into apache:master Oct 7, 2019
@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Oct 7, 2019
@rdhabalia rdhabalia deleted the ns_iso_brk branch October 8, 2019 00:27
@rdhabalia rdhabalia restored the ns_iso_brk branch December 14, 2019 01:10
@tuteng tuteng mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie Awaiting requested review from sijie

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

@jai1 jai1 Awaiting requested review from jai1

@saandrews saandrews Awaiting requested review from saandrews

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@rdhabalia rdhabalia

Labels
area/broker type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdhabalia @merlimat