[pulsar-client] Avoid leak on publish failure on batch message #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Oct 22, 2019
| batchMessageAndSend(); | ||
| batchMessageContainer.add(msg, callback); | ||
| lastSendFuture = callback.getFuture(); | ||
| } finally { |
There was a problem hiding this comment.
If we do get exception here, shouldn't we also trigger the send callback?
There was a problem hiding this comment.
yes, we trigger the callback but we missed to reduce to refCnt of payload in producer so, when callback receives callback, it tries to release payload with refCnt=2 so, producer doesn't release the actual payload.
merlimat
approved these changes
Oct 23, 2019
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
(cherry picked from commit b466b08)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, producer-client tries to add batch message into batch-message-container and it can throw Error/RuntimeException BatchMessageContainer::add eg:
OutOfDirectMemoryError. In this case, pulsar-client is not releasing payload which can leak the memory. SO, make sure to release payload even with any error.