Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero queue consumer message redelivery #6076

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

codelipenghui
Copy link
Contributor

Motivation

Message redelivery is not work well with zero queue consumer when using receive() or listeners to consume messages. This pull request is try to fix it.

Modifications

Add missed trackMessage() method call at zero queue size consumer.

Verifying this change

New unit tests added.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Jan 17, 2020
@codelipenghui codelipenghui added area/client type/bug The PR fixed a bug or issue reported a bug labels Jan 17, 2020
@codelipenghui codelipenghui added this to the 2.5.1 milestone Jan 17, 2020
@codelipenghui
Copy link
Contributor Author

run java8 tests

@jiazhai
Copy link
Member

jiazhai commented Jan 17, 2020

run java8 tests

Failed:
org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadV1

@jiazhai jiazhai merged commit 787bee1 into apache:master Jan 17, 2020
@sijie sijie modified the milestones: 2.5.1, 2.6.0 Jan 22, 2020
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Feb 23, 2020
Motivation
Message redelivery is not work well with zero queue consumer when using receive() or listeners to consume messages. This pull request is try to fix it.

Modifications
Add missed trackMessage() method call at zero queue size consumer.

Verifying this change
New unit tests added.
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
Motivation
Message redelivery is not work well with zero queue consumer when using receive() or listeners to consume messages. This pull request is try to fix it.

Modifications
Add missed trackMessage() method call at zero queue size consumer.

Verifying this change
New unit tests added.

(cherry picked from commit 787bee1)
tuteng pushed a commit that referenced this pull request Apr 13, 2020
Motivation
Message redelivery is not work well with zero queue consumer when using receive() or listeners to consume messages. This pull request is try to fix it.

Modifications
Add missed trackMessage() method call at zero queue size consumer.

Verifying this change
New unit tests added.

(cherry picked from commit 787bee1)
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
Motivation
Message redelivery is not work well with zero queue consumer when using receive() or listeners to consume messages. This pull request is try to fix it.

Modifications
Add missed trackMessage() method call at zero queue size consumer.

Verifying this change
New unit tests added.
(cherry picked from commit 787bee1)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Motivation
Message redelivery is not work well with zero queue consumer when using receive() or listeners to consume messages. This pull request is try to fix it.

Modifications
Add missed trackMessage() method call at zero queue size consumer.

Verifying this change
New unit tests added.
@codelipenghui codelipenghui deleted the zero_queue_consumer_redelivery branch March 3, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client release/2.5.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants