[broker] Restore clusterDispatchRate policy for compatibility #6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
force-pushed
the
restore-cluster-dispatch-rate
branch
from
51aa2c9
to
6ee175b
Compare
sijie
approved these changes
Feb 4, 2020
sijie
added
the
doc-required
massakam
changed the title
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Feb 23, 2020
Co-authored-by: Sijie Guo <guosijie@gmail.com>
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
Co-authored-by: Sijie Guo <guosijie@gmail.com> (cherry picked from commit 9b46930)
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
Co-authored-by: Sijie Guo <guosijie@gmail.com> (cherry picked from commit 9b46930)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
Co-authored-by: Sijie Guo <guosijie@gmail.com> (cherry picked from commit 9b46930)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Co-authored-by: Sijie Guo <guosijie@gmail.com>
Anonymitaet
added
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The other day, our company upgraded Pulsar from 2.3.2 to 2.4.2. Then, the topic-level dispatch throttling no longer works as expected.
This is because the field name that specifies the topic-level dispatch rate has been changed by #4273 from
clusterDispatchRatetotopicDispatchRate. In Pulsar 2.4.0 or later,clusterDispatchRateset for the znodes of namespaces is ignored.The name
topicDispatchRateis more appropriate thanclusterDispatchRate, but I think the value ofclusterDispatchRateset in previous versions should not be ignored.Modifications
Restored
clusterDispatchRatefield inPoliciesclass. IftopicDispatchRateis empty,clusterDispatchRateis referred.