[C++] Fixed handling of canceled timer events on NegativeAcksTracker #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
aahmed-se
approved these changes
Feb 8, 2020
jiazhai
approved these changes
Feb 10, 2020
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Feb 23, 2020
…pache#6272) When handling a "timer cancelled" event, we cannot lock the mutex since the object itself might already be destroyed. This causes potentially a memory corruption/segfault.
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
…pache#6272) When handling a "timer cancelled" event, we cannot lock the mutex since the object itself might already be destroyed. This causes potentially a memory corruption/segfault. (cherry picked from commit 54a5195)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
…pache#6272) When handling a "timer cancelled" event, we cannot lock the mutex since the object itself might already be destroyed. This causes potentially a memory corruption/segfault. (cherry picked from commit 54a5195)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…pache#6272) When handling a "timer cancelled" event, we cannot lock the mutex since the object itself might already be destroyed. This causes potentially a memory corruption/segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When handling a "timer cancelled" event, we cannot lock the mutex since the object itself might already be destroyed.
This causes potentially a memory corruption/segfault.