Fixed casting in ZooKeeperCache.getDataIfPresent() #6313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
sijie
approved these changes
Feb 12, 2020
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Feb 23, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check (cherry picked from commit 7cade48)
tuteng
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check (cherry picked from commit 7cade48)
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check (cherry picked from commit 7cade48)
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
May 15, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check (cherry picked from commit 7cade48)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Fixed casting in ZooKeeperCache.getDataIfPresent() * Missed null check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a casting error in
ZooKeeperCache.getDataIfPresent()which is being called when checking the policies for the publish rate limiter.This result in the rate limiter to not get applied. The error printed is:
10:07:50.378 [bookkeeper-ml-workers-OrderedExecutor-1-0] WARN org.apache.pulsar.broker.service.AbstractTopic - [persistent://public/default/testDelayedMessages-1581070070308] Error getting policies java.util.concurrent.CompletableFuture cannot be cast to org.apache.pulsar.common.policies.data.Policies and publish throttling will be disabled