[Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei… #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimas
changed the title
avimas
changed the title
avimas
changed the title
sijie
added
area/client
java
release/2.5.1
type/bug
jiazhai
reviewed
Feb 25, 2020
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
Outdated
Show resolved
Hide resolved
jiazhai
reviewed
Feb 25, 2020
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
Outdated
Show resolved
Hide resolved
|
overall lgtm. |
|
The failed test is not related to the removal of wildcard imports. |
sijie
approved these changes
Feb 29, 2020
jiazhai
approved these changes
Mar 3, 2020
|
Please rebase master for test @avimas |
|
rebase done |
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
…cheduled twice instead of pendingBatchRecei… (apache#6407) * fix topic discovery task scheduled twice instead of pendingBatchReceiveTask * remove wildcard imports Co-authored-by: avim <avi.maslati@forescout.com> (cherry picked from commit 40995a0)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
…cheduled twice instead of pendingBatchRecei… (apache#6407) * fix topic discovery task scheduled twice instead of pendingBatchReceiveTask * remove wildcard imports Co-authored-by: avim <avi.maslati@forescout.com>(cherry picked from commit 40995a0)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…cheduled twice instead of pendingBatchRecei… (apache#6407) * fix topic discovery task scheduled twice instead of pendingBatchReceiveTask * remove wildcard imports Co-authored-by: avim <avi.maslati@forescout.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the topicPattern feature and found out it is broken due to the discovery task being called twice at the same time for the same topic.
I realized that it is called twice because ConsumerBase class adds itself to the timer upon initialization and its derived class MultiTopicsConsumerImpl is doing the same.
I changed ConsumerBase class to add a specific task without using
this.This change is a trivial
I tested the change in my environment and verified the issue was fixed.
I don't know how to add integration tests yet