Not allow sub auto create by admin when disable topic auto create #6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Apr 7, 2020
sijie
approved these changes
Apr 7, 2020
jiazhai
force-pushed
the
admin_sub_autocreate
branch
from
9f7525a
to
4e7cb11
Compare
sijie
pushed a commit
that referenced
this pull request
Apr 9, 2020
) ### Motivation Not allow sub auto create by admin when disable topic auto create ### Modifications change admin code to not allow sub auto create by admin when disable topic auto create add tests ### Verifying this change ut passed * fix sub auto created by admin * fix test error: create sub partition when update it * fix flaky test
|
@tuteng I cherry-picked the issue into branch-2.5. So it can be released as part of 2.5.2. |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Apr 9, 2020
*Motivation* I cherry-picked the fix of apache#6685 into branch-2.5. But the cherry-pick missing one class import. The pull request fixed the cherry-pick error.
Merged
merlimat
pushed a commit
that referenced
this pull request
Apr 9, 2020
*Motivation* I cherry-picked the fix of #6685 into branch-2.5. But the cherry-pick missing one class import. The pull request fixed the cherry-pick error.
|
Add label release/2.5.1 and remove release/2.5.2 |
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
) ### Motivation Not allow sub auto create by admin when disable topic auto create ### Modifications change admin code to not allow sub auto create by admin when disable topic auto create add tests ### Verifying this change ut passed * fix sub auto created by admin * fix test error: create sub partition when update it * fix flaky test (cherry picked from commit 21f6dcd)
jiazhai
added a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
…ache#6685) ### Motivation Not allow sub auto create by admin when disable topic auto create ### Modifications change admin code to not allow sub auto create by admin when disable topic auto create add tests ### Verifying this change ut passed * fix sub auto created by admin * fix test error: create sub partition when update it * fix flaky test (cherry picked from commit 21f6dcd)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
*Motivation* I cherry-picked the fix of apache#6685 into branch-2.5. But the cherry-pick missing one class import. The pull request fixed the cherry-pick error. (cherry picked from commit 8fcbf43)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ache#6685) ### Motivation Not allow sub auto create by admin when disable topic auto create ### Modifications change admin code to not allow sub auto create by admin when disable topic auto create add tests ### Verifying this change ut passed * fix sub auto created by admin * fix test error: create sub partition when update it * fix flaky test
cbornet
added a commit
to cbornet/pulsar
that referenced
this pull request
Nov 9, 2021
PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
4 tasks
cbornet
added a commit
to cbornet/pulsar
that referenced
this pull request
Nov 10, 2021
PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
cbornet
added a commit
to cbornet/pulsar
that referenced
this pull request
Nov 10, 2021
PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
cbornet
added a commit
to cbornet/pulsar
that referenced
this pull request
Nov 10, 2021
PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
merlimat
pushed a commit
that referenced
this pull request
Dec 9, 2021
) PR #6471 introduced the possibility to set auto topic creation settings at the namespace level PR #6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in #6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
lhotari
pushed a commit
that referenced
this pull request
Dec 10, 2021
) PR #6471 introduced the possibility to set auto topic creation settings at the namespace level PR #6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in #6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation (cherry picked from commit 965a80f)
lhotari
pushed a commit
that referenced
this pull request
Dec 10, 2021
) PR #6471 introduced the possibility to set auto topic creation settings at the namespace level PR #6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in #6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation (cherry picked from commit 965a80f)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 10, 2021
…che#12699) PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation (cherry picked from commit 965a80f) (cherry picked from commit a034d14)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…che#12699) PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Not allow sub auto create by admin when disable topic auto create
Modifications
change admin code to not allow sub auto create by admin when disable topic auto create
add tests
Verifying this change
ut passed