-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed double delete on a namespace #6713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Apr 11, 2020
aahmed-se
approved these changes
Apr 11, 2020
sijie
approved these changes
Apr 11, 2020
@merlimat can you rebase the pull request? |
/pulsarbot run-failure-checks |
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Apr 18, 2020
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Apr 29, 2020
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
May 7, 2020
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
(cherry picked from commit 88f401c)
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
May 15, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Creating and deleting the same namespace twice is raising an error in the cleanup phase. We should ignore the no-node exception during cleanup.