[C++] Fix message id is always the default value in send callback #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run cpp-tests |
|
/pulsarbot run unit-tests |
merlimat
reviewed
Apr 24, 2020
| ASSERT_EQ(ResultOk, result); | ||
| ASSERT_EQ(i, id.batchIndex()); | ||
| sentIdSet.emplace(id); |
There was a problem hiding this comment.
There's no hard guarantee that this callback will be executed before the receive loop is done.
There was a problem hiding this comment.
Thank you for pointing out this! I missed the point that the SendReceipt to producer is not guaranteed to be completed before the consumer's receive() done. I'll do some work on it.
There was a problem hiding this comment.
There is a Latch class in lib/ that might be helpful here.
There was a problem hiding this comment.
Thanks! I found the Latch just now :)
merlimat
approved these changes
Apr 24, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
…ache#6812) * Fix bug: sendCallback's 2nd argument was always the default MessageId * Set batch index for each message's callback of batch * Add test for message id in send callback * Ensure all send callbacks completed before ASSERT_EQ
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
…ache#6812) * Fix bug: sendCallback's 2nd argument was always the default MessageId * Set batch index for each message's callback of batch * Add test for message id in send callback * Ensure all send callbacks completed before ASSERT_EQ
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
May 7, 2020
…ache#6812) * Fix bug: sendCallback's 2nd argument was always the default MessageId * Set batch index for each message's callback of batch * Add test for message id in send callback * Ensure all send callbacks completed before ASSERT_EQ
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
) * Fix bug: sendCallback's 2nd argument was always the default MessageId * Set batch index for each message's callback of batch * Add test for message id in send callback * Ensure all send callbacks completed before ASSERT_EQ (cherry picked from commit fc69a62)
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
…ache#6812) * Fix bug: sendCallback's 2nd argument was always the default MessageId * Set batch index for each message's callback of batch * Add test for message id in send callback * Ensure all send callbacks completed before ASSERT_EQ
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ache#6812) * Fix bug: sendCallback's 2nd argument was always the default MessageId * Set batch index for each message's callback of batch * Add test for message id in send callback * Ensure all send callbacks completed before ASSERT_EQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After commit of #4817, the send callback's 2nd argument became
MessageId, but theMessageIdin callback is always the default value(-1, -1, -1, -1). We need the message id in send callback if messages were sent successfully.The problem is that the correct message id has been retrieved in
ProducerImpl::ackReceivedbut not passed to the user provided callback. Because after messages were sent toBatchMessageContainer, the wrapper of user provided callback used theMessageIdof user constructedMessageas the 2nd argument, which is always(-1, -1, -1, -1).Modifications
messageIdofBatchMessageContainer::MessageContainer. Then addconst MessageId&argument tobatchMessageCallBackinstead.Verifying this change
This change added tests and can be verified as follows:
Run
BasicEndToEndTest.testSendCallbackandBatchMessageTest.testSendCallback.