-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tls with keystore type config support #6853
Conversation
I haven't gone through with the entire change but it seems it touches many different files and I think supporting multiple CA trust stores can be done in an easier way and might not need this big change. @merlimat can you also please review this PR. |
@rdhabalia Thanks for the comments. The name of the PR seems be a little misleading. Changed the name to align with the main changes. It mainly want to support keystore configs. and make multi ca easy config is one result of it. |
I will try to review it soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the change looks good to me. And it is protected by the flag tlsEnabledWithKeyStore
. It seems to be a safe change.
...auth-keystoretls/src/test/java/org/apache/pulsar/client/TlsProducerConsumerTestWithAuth.java
Outdated
Show resolved
Hide resolved
@jiazhai I think we need to add those settings to the configuration files and the website documentation. Can you please create an issue to follow up on a change? |
Hi @rdhabalia Thanks for taking care. If this is too hurry for the review, we could handle it in the following issues and prs. |
...-keystoretls/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationKeyStoreTls.java
Outdated
Show resolved
Hide resolved
related with #6853 add keystore tls config doc
some files are left unused, in #6853. this pr is to remove them
Fixes apache#6640 ### Motivation Add Tls with keystore type config. ### Modifications Add Tls with keystore type config. ### Verifying this change - Unit test passed
related with apache#6853 add keystore tls config doc
some files are left unused, in apache#6853. this pr is to remove them
Fixes apache#6640 Add Tls with keystore type config. Add Tls with keystore type config. - Unit test passed (cherry picked from commit 367ce78)
related with apache#6853 add keystore tls config doc (cherry picked from commit fd6f772)
Motivation This doc PR is updated for configurations for PRs: #6716 #6853 #6074 1: The broker configuration (for #6716) is updated by Jia Zhai. 2: Add other supported configurations to the client, standlone and proxy configuration docs based on the client.config, standlone.config and proxy.config files. Modifications 1: Add TLS with keystore type config in standlone and proxy configuration file. 2: update reference > pulsar configuration > client for PIP-55: Refresh Authentication Credentials Add other supported configurations to the standlone and proxy configuration files based on the standlone.config and proxy.config files.
Fixes apache#6640 ### Motivation Add Tls with keystore type config. ### Modifications Add Tls with keystore type config. ### Verifying this change - Unit test passed
related with apache#6853 add keystore tls config doc
some files are left unused, in apache#6853. this pr is to remove them
Motivation This doc PR is updated for configurations for PRs: apache#6716 apache#6853 apache#6074 1: The broker configuration (for apache#6716) is updated by Jia Zhai. 2: Add other supported configurations to the client, standlone and proxy configuration docs based on the client.config, standlone.config and proxy.config files. Modifications 1: Add TLS with keystore type config in standlone and proxy configuration file. 2: update reference > pulsar configuration > client for PIP-55: Refresh Authentication Credentials Add other supported configurations to the standlone and proxy configuration files based on the standlone.config and proxy.config files.
Fixes #6640
Motivation
Add Tls with keystore type config.
Modifications
Add Tls with keystore type config.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation