Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update for acknowledgment at batch index level #7018

Conversation

Huanli-Meng
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? ( docs )
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Huanli-Meng
Copy link
Contributor Author

Update docs for the acknowledgment at batch index level:

  1. messaging concepts: update the batching and acknowledgement.
  2. reference > pulsar configuration: update broker configuration.

@Huanli-Meng
Copy link
Contributor Author

Update the doc for the PR: #6052

@codelipenghui codelipenghui added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 25, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone May 25, 2020
Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
@jiazhai jiazhai merged commit 973e4cc into apache:master May 30, 2020
Huanli-Meng added a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
* [Doc] Update for acknowledgment at batch index level

* Update site2/docs/concepts-messaging.md
Huanli-Meng added a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
* [Doc] Update for acknowledgment at batch index level

* Update site2/docs/concepts-messaging.md
Huanli-Meng added a commit to Huanli-Meng/pulsar that referenced this pull request Jun 12, 2020
* [Doc] Update for acknowledgment at batch index level

* Update site2/docs/concepts-messaging.md
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
* [Doc] Update for acknowledgment at batch index level

* Update site2/docs/concepts-messaging.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants