Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only close active consumer for Failover subscription when seek(). #7141

Merged
merged 4 commits into from
Jun 3, 2020

Conversation

codelipenghui
Copy link
Contributor

Related to #5278

Motivation

Only close active consumer for Failover subscription when seek().

Verifying this change

Unit tests added

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui requested review from massakam, merlimat, rdhabalia, jiazhai and sijie and removed request for massakam and merlimat June 2, 2020 09:57
@codelipenghui codelipenghui self-assigned this Jun 2, 2020
@codelipenghui codelipenghui added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jun 2, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone Jun 2, 2020
@gaoran10
Copy link
Contributor

gaoran10 commented Jun 3, 2020

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit dbe5903 into apache:master Jun 3, 2020
@codelipenghui codelipenghui deleted the close_consumer_seek branch June 3, 2020 09:52
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
…ache#7141)

Related to apache#5278 

### Motivation

Only close active consumer for Failover subscription when seek().

### Verifying this change

Unit tests added

### Does this pull request potentially affect one of the following parts:

*If `yes` was chosen, please highlight the changes*

  - Dependencies (does it add or upgrade a dependency): ( no)
  - The public API: (no)
  - The schema: (no)
  - The default values of configurations: (no)
  - The wire protocol: (no)
  - The rest endpoints: (no)
  - The admin cli options: (no)
  - Anything that affects deployment: (no)

### Documentation

  - Does this pull request introduce a new feature? (no)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants