During Function update, cleanup should only happen for temp files that were generated #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp files that were generated
jerrypeng
reviewed
Jun 9, 2020
| && componentPackageFile != null && componentPackageFile.exists()) { | ||
| componentPackageFile.delete(); | ||
| if (componentPackageFile != null && componentPackageFile.exists()) { | ||
| if ((functionPkgUrl != null && !functionPkgUrl.startsWith(Utils.FILE)) || uploadedInputStream != null) { |
There was a problem hiding this comment.
Do we also need to exclude "http" ?
There was a problem hiding this comment.
Do we need to add this for sources and sinks as well?
There was a problem hiding this comment.
no. Only file. Since for http(or others) we will make a copy and do validation on that copy. We need to cleanup this copy.
There was a problem hiding this comment.
good catch about sources/sinks. Will add
There was a problem hiding this comment.
Added the same logic for sources/sinks
jerrypeng
approved these changes
Jun 9, 2020
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Jun 30, 2020
…t were generated (apache#7201) * Fix logic while updating functions. Cleanup should only happen for temp files that were generated * Fix integration tests * Fix test * Fix logic for parallelism > 1 * Fix test * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…t were generated (apache#7201) * Fix logic while updating functions. Cleanup should only happen for temp files that were generated * Fix integration tests * Fix test * Fix logic for parallelism > 1 * Fix test * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
zymap
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Oct 1, 2020
…t were generated (apache#7201) * Fix logic while updating functions. Cleanup should only happen for temp files that were generated * Fix integration tests * Fix test * Fix logic for parallelism > 1 * Fix test * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
|
needs to cherry-pick to 2.6.2. |
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
…t were generated (#7201) * Fix logic while updating functions. Cleanup should only happen for temp files that were generated * Fix integration tests * Fix test * Fix logic for parallelism > 1 * Fix test * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com> (cherry picked from commit 828d033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
When doing function updates, cleanup should only be done for files that were temporarily created.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation