[Issue 7168][C++] Fix pattern consumer's deadlock for topics auto discovery #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jun 9, 2020
|
/pulsarbot run-failure-checks |
BewareMyPower
changed the title
sijie
approved these changes
Jun 9, 2020
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
…auto discovery (apache#7206) Fixes apache#7168 ### Motivation When a pattern consumer is blocked by `receive()`, the `mutex_` will be held until new messages arrived. If the auto discovery timer task found new topics and tried to subscribe them, `mutex_` must be acquired first, then the deadlock happened. ### Modifications - Release the `mutex_` after the consumer's state was verified. - Change unit tests to verify that new topics could be subscribed when the consumer's blocked by `receive(Message&)` or `receive(Message&, int)` methods. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as *BasicEndToEndTest.testPatternMultiTopicsConsumerAutoDiscovery*.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…auto discovery (apache#7206) Fixes apache#7168 ### Motivation When a pattern consumer is blocked by `receive()`, the `mutex_` will be held until new messages arrived. If the auto discovery timer task found new topics and tried to subscribe them, `mutex_` must be acquired first, then the deadlock happened. ### Modifications - Release the `mutex_` after the consumer's state was verified. - Change unit tests to verify that new topics could be subscribed when the consumer's blocked by `receive(Message&)` or `receive(Message&, int)` methods. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as *BasicEndToEndTest.testPatternMultiTopicsConsumerAutoDiscovery*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7168
Motivation
When a pattern consumer is blocked by
receive(), themutex_will be held until new messages arrived. If the auto discovery timer task found new topics and tried to subscribe them,mutex_must be acquired first, then the deadlock happened.Modifications
mutex_after the consumer's state was verified.receive(Message&)orreceive(Message&, int)methods.Verifying this change
This change is already covered by existing tests, such as BasicEndToEndTest.testPatternMultiTopicsConsumerAutoDiscovery.