Fixed logic for forceful topic deletion #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng,
aahmed-se and
codelipenghui
srkukarni
approved these changes
Jun 26, 2020
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Jun 30, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
zymap
pushed a commit
that referenced
this pull request
Mar 2, 2021
(cherry picked from commit 53bc73c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the topic deletion, during the removal of non-durable subscriptions, there is a race condition that leads to a state the topic cannot get deleted anymore, not even forcefully, until it gets unloaded/reloaded.
The log trace is:
There are a couple of issues here:
The
isFencedflag is only set after all producers/consumers are disconnected, but that won't prevent the from reconnecting.We're doing these 3 operations in steps:
The problem with (2) is that, for a non-durable subscription, the cursor is already deleted after (1), so the unsubscribing will fail there.
When deleting the topic, all the cursors are going to get deleted when the managed ledger is deleted. There is no need to pre-delete all of them.
Regarding
USAGE_COUNT_UPDATER, if we're trying to force-delete operation, this operation should go through even if the counter is not correct. (eg: after the effects of Handling error in creation of non-durable cursor #7355)Fixed one case in which
USAGE_COUNT_UPDATERwasn't decremented after an error.