Migrate github actions to use container images #7603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
force-pushed
the
github_ci_exp
branch
25 times, most recently
from
714f2d5
to
206b3bd
Compare
merlimat
reviewed
Jul 21, 2020
aahmed-se
force-pushed
the
github_ci_exp
branch
4 times, most recently
from
7235917
to
532e69b
Compare
merlimat
reviewed
Jul 22, 2020
| run: mvn test -DfailIfNoTests=false -pl pulsar-broker-auth-sasl | ||
| - name: run unit tests for pulsar-broker | ||
| run: | | ||
| mvn -B -q -ntp install -pl pulsar-broker -am -DskipTests |
There was a problem hiding this comment.
This would be fetching snapshot dependencies for other modules and it will fail to compile whenever a commit is also touching more than just pulsar-broker. Rather why not just do install with -Pcore-modules
aahmed-se
force-pushed
the
github_ci_exp
branch
3 times, most recently
from
de0ccbf
to
5dfa910
Compare
aahmed-se
changed the title
aahmed-se
force-pushed
the
github_ci_exp
branch
2 times, most recently
from
e0a68d7
to
36aea9d
Compare
aahmed-se
force-pushed
the
github_ci_exp
branch
3 times, most recently
from
e9b2e0d
to
bce79bb
Compare
* Unit test and go function tests are not consistent in runtime behavior
aahmed-se
changed the title
merlimat
approved these changes
Jul 23, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Jul 25, 2020
* Add server bind address to proxy webserver * Force executor shutdown in mocks * Add config for surefire reuseForks and forkCount * Fix ProxyTest#testRegexSubscription * Migrate github actions to use container images * Unit test and go function tests are not consistent in runtime behavior Co-authored-by: Ali Ahmed <alia@splunk.com> (cherry picked from commit 67bd345)
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Aug 14, 2020
* Add server bind address to proxy webserver * Force executor shutdown in mocks * Add config for surefire reuseForks and forkCount * Fix ProxyTest#testRegexSubscription * Migrate github actions to use container images * Unit test and go function tests are not consistent in runtime behavior Co-authored-by: Ali Ahmed <alia@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Add server bind address to proxy webserver * Force executor shutdown in mocks * Add config for surefire reuseForks and forkCount * Fix ProxyTest#testRegexSubscription * Migrate github actions to use container images * Unit test and go function tests are not consistent in runtime behavior Co-authored-by: Ali Ahmed <alia@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the transition we are adding additional commits to this pr fix test issues.