Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deduplication cursor does not delete after disabling message deduplication #7656

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Fix deduplication cursor does not delete after disabling message deduplication #7656

merged 5 commits into from
Jul 30, 2020

Conversation

codelipenghui
Copy link
Contributor

Motivation

Fix deduplication cursor does not delete after disabling message deduplication. The issue occurs when enabling the message deduplication at the broker.conf and then disable it and restart the broker. The dedup cursor will not be deleted.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: ( no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Jul 24, 2020
@codelipenghui codelipenghui added release/2.6.1 type/bug The PR fixed a bug or issue reported a bug labels Jul 24, 2020
@codelipenghui codelipenghui added this to the 2.7.0 milestone Jul 24, 2020
@codelipenghui
Copy link
Contributor Author

related to #7345

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@wolfstudy
Copy link
Member

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@wolfstudy
Copy link
Member

/pulsarbot run-failure-checks

@wolfstudy
Copy link
Member 

org.apache.pulsar.broker.loadbalance.AntiAffinityNamespaceGroupTest
[ERROR] testBrokerSelectionForAntiAffinityGroup(org.apache.pulsar.broker.loadbalance.AntiAffinityNamespaceGroupTest)  Time elapsed: 0.151 s  <<< FAILURE!
java.lang.AssertionError: null
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.assertNotEquals(Assert.java:1157)
	at org.testng.Assert.assertNotEquals(Assert.java:1162)
	at org.apache.pulsar.broker.loadbalance.AntiAffinityNamespaceGroupTest.testBrokerSelectionForAntiAffinityGroup(AntiAffinityNamespaceGroupTest.java:423)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@wolfstudy
Copy link
Member

wolfstudy commented Jul 28, 2020 •
edited
Loading

@codelipenghui Please check the test case, thanks

[ERROR] testAckCommand(org.apache.pulsar.broker.service.ServerCnxTest)  Time elapsed: 10.148 s  <<< FAILURE!
java.io.IOException: Failed to get response from socket within 10s
	at org.apache.pulsar.broker.service.ServerCnxTest.getResponse(ServerCnxTest.java:1459)
	at org.apache.pulsar.broker.service.ServerCnxTest.testAckCommand(ServerCnxTest.java:1250)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 2bba620 into apache:master Jul 30, 2020
@codelipenghui codelipenghui deleted the penghui/fix-dedup-cursor-remove-issue branch July 30, 2020 01:06
wolfstudy pushed a commit that referenced this pull request Jul 30, 2020
@codelipenghui @wolfstudy
Fix deduplication cursor does not delete after disabling message dedu…
0a19dec 
…plication (#7656)

### Motivation

Fix deduplication cursor does not delete after disabling message deduplication. The issue occurs when enabling the message deduplication at the broker.conf and then disable it and restart the broker. The dedup cursor will not be deleted.

(cherry picked from commit 2bba620)
@codelipenghui codelipenghui mentioned this pull request Aug 11, 2020
Closed
jerrypeng pushed a commit to jerrypeng/incubator-pulsar that referenced this pull request Aug 14, 2020
@codelipenghui @merlimat
Fix deduplication cursor does not delete after disabling message dedu…
a996dc0 
…plication (apache#7656)

### Motivation

Fix deduplication cursor does not delete after disabling message deduplication. The issue occurs when enabling the message deduplication at the broker.conf and then disable it and restart the broker. The dedup cursor will not be deleted.
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@codelipenghui @huangdx0726
Fix deduplication cursor does not delete after disabling message dedu…
4f6772a 
…plication (apache#7656)

### Motivation

Fix deduplication cursor does not delete after disabling message deduplication. The issue occurs when enabling the message deduplication at the broker.conf and then disable it and restart the broker. The dedup cursor will not be deleted.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@codelipenghui
Fix deduplication cursor does not delete after disabling message dedu…
e68bc44 
…plication (apache#7656)

### Motivation

Fix deduplication cursor does not delete after disabling message deduplication. The issue occurs when enabling the message deduplication at the broker.conf and then disable it and restart the broker. The dedup cursor will not be deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@sijie sijie Awaiting requested review from sijie

Assignees

@codelipenghui codelipenghui

Labels
release/2.6.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@codelipenghui @wolfstudy @jiazhai