[Issue] Fix get schemaName by partitioned topic name #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
reviewed
Jul 31, 2020
| @@ -342,7 +342,9 @@ public boolean isGlobal() { | |||
| public String getSchemaName() { | |||
| return getTenant() | |||
| + "/" + getNamespacePortion() | |||
| + "/" + getEncodedLocalName(); | |||
| + "/" + (isPartitioned() ? | |||
There was a problem hiding this comment.
getPartitionedTopicName already implemented the functionality
There was a problem hiding this comment.
Ok, I could reuse it, but the method getPartitionedTopicName will return a complete topic name with the domain. Maybe I could get the encodedLocalName in this way.
TopicName.get(getPartitionedTopicName()).getEncodedLocalName()
|
/pulsarbot run-failure-checks |
5 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Aug 3, 2020
codelipenghui
added
release/2.6.1
component/schemaregistry
type/bug
gaoran10
force-pushed
the
get-schema-partition
branch
from
e517ec2
to
09b1e02
Compare
wolfstudy
pushed a commit
that referenced
this pull request
Aug 5, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#7676 ### Motivation Currently, there is an error that gets schemaName by partitioned topic name. ### Modifications Add partitioned check in method `topicName. getSchemaName()`.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7676 ### Motivation Currently, there is an error that gets schemaName by partitioned topic name. ### Modifications Add partitioned check in method `topicName. getSchemaName()`.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7676 ### Motivation Currently, there is an error that gets schemaName by partitioned topic name. ### Modifications Add partitioned check in method `topicName. getSchemaName()`.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7676 ### Motivation Currently, there is an error that gets schemaName by partitioned topic name. ### Modifications Add partitioned check in method `topicName. getSchemaName()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7676
Motivation
Currently, there is an error that gets schemaName by partitioned topic name.
Modifications
Add partitioned check in method
topicName. getSchemaName().Verifying this change
Add a new unit test.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation