[broker] Make resetting cursor in REST API asynchronous #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
type/bug
merlimat
approved these changes
Aug 4, 2020
massakam
force-pushed
the
reset-cursor-async
branch
from
cbf7194
to
5fe7e5f
Compare
massakam
commented
Aug 5, 2020
| @@ -232,7 +232,6 @@ public void testTerminatePartitionedTopic() { | |||
|
|
|||
| @Test | |||
| public void testNonPartitionedTopics() { | |||
| pulsar.getConfiguration().setAllowAutoTopicCreation(false); | |||
There was a problem hiding this comment.
This test fails if allowAutoTopicCreation is false.
We are testing if the subscription creation is successful here. However, if allowAutoTopicCreation is false, the topic cannot be created and the subscription creation should also fail.
I think it's a mistake to set allowAutoTopicCreation to false here. Previously this test passed because the REST API was not able to return the error response correctly.
sijie
approved these changes
Aug 6, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation As mentioned in apache#7478, `PersistentSubscription#resetCursor()` may not complete for unknown reasons. This blocks `pulsar-web` threads, so it can cause the broker server to be unable to respond to HTTP requests. ### Modifications Get the result of `PersistentSubscription#resetCursor()` asynchronously so as not to block `pulsar-web` threads.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation As mentioned in apache#7478, `PersistentSubscription#resetCursor()` may not complete for unknown reasons. This blocks `pulsar-web` threads, so it can cause the broker server to be unable to respond to HTTP requests. ### Modifications Get the result of `PersistentSubscription#resetCursor()` asynchronously so as not to block `pulsar-web` threads.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation As mentioned in apache#7478, `PersistentSubscription#resetCursor()` may not complete for unknown reasons. This blocks `pulsar-web` threads, so it can cause the broker server to be unable to respond to HTTP requests. ### Modifications Get the result of `PersistentSubscription#resetCursor()` asynchronously so as not to block `pulsar-web` threads.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation As mentioned in apache#7478, `PersistentSubscription#resetCursor()` may not complete for unknown reasons. This blocks `pulsar-web` threads, so it can cause the broker server to be unable to respond to HTTP requests. ### Modifications Get the result of `PersistentSubscription#resetCursor()` asynchronously so as not to block `pulsar-web` threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in #7478,
PersistentSubscription#resetCursor()may not complete for unknown reasons. This blockspulsar-webthreads, so it can cause the broker server to be unable to respond to HTTP requests.Modifications
Get the result of
PersistentSubscription#resetCursor()asynchronously so as not to blockpulsar-webthreads.