[Transaction] Txn ack abort process on subscription #7979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
@codelipenghui @zymap @congbobo184 to help review this PR. |
codelipenghui
approved these changes
Sep 8, 2020
codelipenghui
changed the title
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Fixes https://github.com/streamnative/pulsar/issues/1314 ### Motivation Currently, the transaction ack abort process is not well. ### Modifications Make some changes for the transaction ack abort process.
codelipenghui
added
component/transaction
area/transaction
and removed
component/transaction
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/streamnative/pulsar/issues/1314
Motivation
Currently, the transaction ack abort process is not well.
Modifications
Make some changes for the transaction ack abort process.
Verifying this change
This change added tests and can be verified as follows:
-org.apache.pulsar.broker.transaction.TransactionProduceTest#ackAbortTest
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation